You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I looked through the changes in this PR. Everything is clear.
One important point: Please add in the version release that will include this PR that the definition of G has changed. As and M_down are also changed, but they are also renamed to B and M_Ghosh, respectively, meaning that there is no risk of any code utilizing pymrio to take over the changes unnoticeable. However, as G changed definition but not the object name this could go unnoticed with switching to a new pymrio-version. We have code that does make use of the old definition of G, which will require a few changes to the implementation.
On my side, I will make sure that we switch to the new pymrio version that includes this PR as an organization in one go, rewriting our code that makes use of the previous definition of G and ensuring that older pymrio versions cannot be used thereafter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See TODO.md for work that is still to be done.